Use the requested log level when handling broken stdout pipe #6153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #5907.
I noticed a tiny issue where, if a broken stdout pipe occurs and the user passed
--log
, then pip will print the traceback for the broken pipe even if the user didn't request verbose logging. This is because pip sets the root logger level toDEBUG
if--log
is passed:pip/src/pip/_internal/utils/logging.py
Lines 233 to 238 in fc9bb60
This PR changes the logic inside inside the base
Command.main()
to use the user's requested log level instead of the root logger level when deciding whether to print the broken pipe traceback.