Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite readme and index #6205

Merged
merged 4 commits into from
Jan 28, 2019
Merged

Rewrite readme and index #6205

merged 4 commits into from
Jan 28, 2019

Conversation

theacodes
Copy link
Member

Resolves #5815

pradyunsg
pradyunsg approved these changes Jan 26, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@theacodes
Copy link
Member Author

@pradyunsg anything else I need to do to get this merged?

cjerdonek
cjerdonek reviewed Jan 26, 2019
View reviewed changes
Copy link
Member

@cjerdonek cjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few simple comments.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
@hugovk hugovk mentioned this pull request Jan 27, 2019
Closed
@cjerdonek cjerdonek added the type: docs Documentation related label Jan 28, 2019
@pradyunsg pradyunsg mentioned this pull request Jan 28, 2019
Closed
@pradyunsg
Copy link
Member

Oh oh oh, Azure Devops is running tests for everything even on docs-only changes.

cjerdonek
cjerdonek approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@cjerdonek cjerdonek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, well I still don't think it makes sense to link to virtualenv's mailing list on pip's project page (I suggested deleting it for now), but I won't hold this up.

@pradyunsg pradyunsg merged commit d9de37d into pypa:master Jan 28, 2019
@pradyunsg
Copy link
Member

Let's get this in; I'll update that link in a bit. :)

@pradyunsg
Copy link
Member

Thanks for this @theacodes! :)

@theacodes
Copy link
Member Author

theacodes commented Jan 28, 2019 via email

@lock
Copy link

lock bot commented May 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@pfmoore pfmoore pfmoore left review comments

@cjerdonek cjerdonek cjerdonek approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation type: docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the documentation landing page
4 participants
@theacodes @pradyunsg @cjerdonek @pfmoore