Update flake8 to 3.7.6 #6282
Merged
Update flake8 to 3.7.6 #6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
Feb 22, 2019
| @@ -227,7 +227,7 @@ def _get_html_page(link, session=None): | |||
|
|
|||
| try: | |||
| resp = _get_html_response(url, session=session) | |||
| except _NotHTTP as exc: | |||
| except _NotHTTP: | |||
There was a problem hiding this comment.
Can you move this into a separate commit from removing #noqa?
| from typing import ( # noqa: F401 | ||
| List, Union | ||
| ) | ||
| from typing import List |
There was a problem hiding this comment.
I'd be fine with keeping Union here in this commit, and removing it the next commit.
There was a problem hiding this comment.
There's a few places other places too which remove not-used imports, it'd be nice if all of those changes could be moved into a separate commit.
pradyunsg
added
skip news
mkurnikov
force-pushed
the
update-flake8-to-3.7.6
branch
from
8b569fb to
c4dfdbe
Compare
|
Done. (force-push, so explicit notification) |
|
Gee. Thanks for the quick turn around! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pradyunsg
Sorry, I messed up history in the original #6227, here is a new one, with the same changes, but
flake8updated to very latest version.