Simplify FoundCandidates #6684
Merged
Simplify FoundCandidates #6684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
C: finder
|
Thanks! |
xavfernandez
reviewed
Jul 8, 2019
| self._candidates = candidates | ||
| self._evaluator = evaluator | ||
| self._versions = versions |
There was a problem hiding this comment.
Late nit: I'd put an assert set(self._applicable_candidates) <= set(self._candidates) to make sure args are coherent.
There was a problem hiding this comment.
Thanks for taking a look, @xavfernandez. I'll do this in a future PR.
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the
FoundCandidatesclass by moving the calculation logic inFoundCandidates.iter_applicable()into themake_found_candidates()function that creates aFoundCandidatesobject.This makes it so
FoundCandidatesbehaves more like a simple container. It also makes it so that the determination of applicable candidates happens just once when theFoundCandidatesobject is created, instead of each time one wants to iterate over the applicable candidates.This PR also adds the first test of the
make_found_candidates()method.This PR will come in handy for some later PR's.