Reduce context/options passed to Resolver #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
changed the title
chrahunt
added
skip news
4 tasks
pradyunsg
approved these changes
Sep 7, 2019
There was a problem hiding this comment.
LGTM.
My only concern is a naming one -- Provider is a concept, in the resolution model that we'll be adopting from resolvelib/zazo. That said, this bit of code will move out the Resolver while we're working on adopting that model so I'll merge this in right now.
pradyunsg
changed the title
|
I did see that. I hope they can all get along, provider is one of my go-to class suffixes. ;) |
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Sep 17, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing data and having
ResolverconstructInstallRequirements, we pass a function that does it.