Fix Windows folder writable detection #8025
Conversation
| @@ -161,7 +161,7 @@ def _test_writable_dir_win(path): | |||
| except OSError as e: | |||
| if e.errno == errno.EEXIST: | |||
| continue | |||
| if e.errno == errno.EPERM: | |||
| if e.errno == errno.EPERM or e.errno == errno.EACCES: | |||
| # This could be because there's a directory with the same name. | |||
| # But it's highly unlikely there's a directory called that, | |||
| # so we'll assume it's because the parent dir is not writable. | |||
There was a problem hiding this comment.
You can update the comment as well indicating the other reason, this would return False.
|
I’m OK with the fix ( Also, you will need to add a news fragment describing the change. Please take a look at the development guide to learn how. |
|
Maybe a subprocess is need to run The original code was copied from Flit, in which |
|
pip already run subprocesses in tests. Would it be possible to extend If not, I think it’d be enough to simply add a comment to the copied functions pointing to Flit’s corresponding code, and describe briefly how they are ported to Python 2. |
|
Thanks for the contribution, @catPill 🙂 |
lock
bot
added
the
auto-locked
Fixes #8013