Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use cElementTree on Python 3 #8278

Merged
merged 5 commits into from
May 30, 2020
Merged

Don't use cElementTree on Python 3 #8278

merged 5 commits into from
May 30, 2020

Conversation

tiran
Copy link
Contributor

@tiran tiran commented May 20, 2020

It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't
have cElementTree. I'd like to bring it back with a deprecation warning
to drop in 3.10.

See: python/cpython#19921
Signed-off-by: Christian Heimes christian@python.org

tiran added 2 commits May 21, 2020 00:21
@tiran
Don't use cElementTree on Python 3
bf31e53 
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't
have cElementTree. I'd like to bring it back with a deprecation warning
to drop in 3.10.

See: python/cpython#19921
Signed-off-by: Christian Heimes <christian@python.org>
@tiran
news entry
4333333
uranusjr
uranusjr reviewed May 21, 2020
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn’t realise this is updating a vendor library. This will probably need to be filed upstream.

@uranusjr uranusjr requested review from uranusjr and removed request for uranusjr May 21, 2020 03:48
@uranusjr uranusjr mentioned this pull request May 21, 2020
Closed
@uranusjr
Copy link
Member

I’ve filed html5lib/html5lib-python#494 upstream.

@uranusjr uranusjr added the project: vendored dependency Related to a vendored dependency label May 21, 2020
@tiran
Copy link
Contributor Author

tiran commented May 21, 2020

I’ve filed html5lib/html5lib-python#494 upstream.

Fantastic, thank you. I wasn't sure how pip handles changes to vendored packages.

@pradyunsg
Copy link
Member

I wasn't sure how pip handles changes to vendored packages.

We hold patches to vendored packages in tools/automation/vendoring/patches. This PR will need to be updated to add a patch for the change you've made.

If I remember correctly, you'll have to take the "inverse" of the output from the failing CI job: https://travis-ci.org/github/pypa/pip/jobs/689445394

@tiran
Copy link
Contributor Author

tiran commented May 21, 2020

I wasn't sure how pip handles changes to vendored packages.

We hold patches to vendored packages in tools/automation/vendoring/patches. This PR will need to be updated to add a patch for the change you've made.

If I remember correctly, you'll have to take the "inverse" of the output from the failing CI job: travis-ci.org/github/pypa/pip/jobs/689445394

It looks like it's git format-patch output (excluding the header and footer)

@tiran
Copy link
Contributor Author

tiran commented May 21, 2020

@pradyunsg tests are passing now, thanks for your assist!

@pradyunsg pradyunsg closed this May 23, 2020
@pradyunsg pradyunsg reopened this May 23, 2020
@pradyunsg
Copy link
Member

Flaky flaky CI. 😡

@pradyunsg
Copy link
Member

pradyunsg commented May 30, 2020 •
edited
Loading

Gah. A single check isn't reporting and it's a check that shouldn't be affecting by this change per-se. I'm gonna go ahead and merge this. Thanks @tiran! ^>^

@pradyunsg pradyunsg merged commit d01bfcf into pypa:master May 30, 2020
@gsnedders gsnedders mentioned this pull request Jun 10, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
project: vendored dependency Related to a vendored dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiran @uranusjr @pradyunsg