Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise lazy wheel and its tests #8584

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Conversation

McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Jul 15, 2020

This PR aims to do two things

  • Raise HTTPRangeRequestUnsupported instead of RuntimeError when range request is not supported
  • Use local server to not support range request in a unit test

At the moment I haven't quite figured out how to use pallets/werkzeug#978 as suggested by @chrahunt in #8532 (comment).

@pradyunsg
Copy link
Member

CI hasn't triggered for this PR for some reason. Huh.

@chrahunt chrahunt added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jul 15, 2020
@pradyunsg pradyunsg closed this Jul 16, 2020
@pradyunsg pradyunsg reopened this Jul 16, 2020
@pradyunsg
Copy link
Member

That should help?

@McSinyx
Copy link
Contributor Author

McSinyx commented Jul 16, 2020

I've just pushed a new commit and the CIs are getting the hook now. I've been spending so much time on this so I guess I'll switch back to implementing the integration of the utilities. This is wearing me out and being stressed about not getting things done makes me even less productive 😄

The part I'm particularly stuck at is (I think, regarding the error log) how to provide the response for HEAD requests and probably the mock server doesn't handle multiple requests: 7df1646. Mainly because I couldn't found the part of tutorial referring to what pip is doing currently.

@pradyunsg
Copy link
Member

HEAD requests

I think we should do that in an follow up PR - this change as is is pretty atomic and does one thing (which makes it easier to review, discuss etc).

@McSinyx
Copy link
Contributor Author

McSinyx commented Jul 16, 2020

I'm happy to reset to da574fb and revisit the mock server supporting range request thing when I'm emotionally recovered from this and/or these tests show to have too much negative effect on the whole suit. I also figure that it's not likely that we should mock a server with all the dependencies for the integration tests.

@McSinyx McSinyx force-pushed the range-unsupported-exc branch from 7df1646 to 892018e Compare July 16, 2020 14:10
@McSinyx McSinyx marked this pull request as ready for review July 16, 2020 14:10
@McSinyx McSinyx closed this Jul 17, 2020
@McSinyx McSinyx reopened this Jul 17, 2020
@McSinyx
Copy link
Contributor Author

McSinyx commented Jul 19, 2020

@pradyunsg, is there anything you'd like to iterate on before merging?

@pradyunsg pradyunsg merged commit 982aac5 into pypa:master Jul 21, 2020
@pradyunsg
Copy link
Member

@pradyunsg, is there anything you'd like to iterate on before merging?

Nope -- LGTM.

@McSinyx McSinyx deleted the range-unsupported-exc branch July 21, 2020 08:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants