-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore a broken slug anchor in user guide #8781
Conversation
Rendered preview to confirm the anchor is fixed. Test failures are unrelated, caused by availability issues of http://svn.colorstudy.com. Can you add a |
LGTM after add news |
Linting error is
Seems unrelated? But why does master not fail? |
hmm weird, what about re run? |
Same here: #8771 |
@uranusjr I can reproduce the error locally. I'm not expert with sphinx but seems that the reference to https://github.com/pypa/packaging.python.org/blame/master/source/glossary.rst#L209 is not successfully.
IMO there is some new on sphinx that break that behaviour. But again, I'm not expert and I don't have evidences of the problem. Tomorrow I can continue looking that |
It's case-sensitive now, IIUC -- maybe that's why? |
https://travis-ci.com/github/pypa/pip/jobs/375534050 -- looks like master is failing as well. |
Unlikely, since only in the error that it is Line 42 in e1d489f
As analyzed by @shireenrao in #8650 (comment), this might have to do with Sphinx version compatibility (given the PUG has recently upgraded to use Sphinx 3.2.0). |
I believe that this was closed accidentally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Happy to merge once CI is green (which it should be soon-enough). :)
ping @uranusjr , @di