Order resolution preference by command ordering #9426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
new-resolver-resolve-user-order
branch
from
463f42b to
0866bfa
Compare
|
You do know you can add a "trivial" label to satisfy the CI check for a news item? |
pfmoore
approved these changes
Jan 4, 2021
|
FWIW, .trivial files with some content also work. Only empty ones would fail. |
|
Why do empty ones fail? Is that this CI bug I've been seeing people comment on? |
|
Yes. pypa/browntruck#24 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9316. The order requirements are specified from the command line (and requirements files) are now carried into the provider, and used to determine preferences. Non-user-specified requirements have
float('inf'), i.e. always resolved after user-specified requiremenets.I’m intentionally omitting a news fragment so this change does not show up in the release notes. Otherwise users may (incorrectly) assume this is actually a guarenteed behaviour.