write pip delete marker into global build dir upon creation #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwcode
added a commit
that referenced
this pull request
May 19, 2013
write pip delete marker into global build dir upon creation
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a "partial" fix for #939.
this change writes the pip delete marker into the global build dir upon creation, so it can be removed during the cleanup step.
this change is not helpful if the user already has the global build dir, which will be most pre-existing users. so, this fix is not so exciting.
#906 (in milestone 1.5), intends to handle this better by moving to mkdtemp build dirs in all cases.