Parse pkg_resources Dist versions with packaging.version #9676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
force-pushed
the
re-parse-version
branch
from
2e3282d to
cdd8df3
Compare
Due to a mix of bundled and unbundled dependencies, pkg_resources Version class may not be the same as packaging's Version class. See: pypa/setuptools#2052
stefanor
force-pushed
the
re-parse-version
branch
from
cdd8df3 to
8f2e3d6
Compare
uranusjr
added
the
skip news
uranusjr
reviewed
Mar 2, 2021
|
Changes lgtm, but I have a fear of missing something, seeing Mypy making seemingly impossible inferences. |
uranusjr
approved these changes
Mar 4, 2021
|
I plan to merge this at the end of this weekend if no-one objects. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a mix of bundled and unbundled dependencies, pkg_resources
Version class may not be the same as packaging's Version class.
See: pypa/setuptools#2052
As discussed in #9467