Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to install provides_extras from local wheel file #9698

Merged
merged 4 commits into from
Jul 25, 2021
Merged

Document how to install provides_extras from local wheel file #9698

merged 4 commits into from
Jul 25, 2021

Conversation

johnthagen
Copy link
Contributor

Closes #9694

docs/html/user_guide.rst Outdated Show resolved Hide resolved
@johnthagen
Copy link
Contributor Author

@uranusjr Could you add the label to skip news-file for this PR? I presume this isn't large enough to warrant a news entry.

@uranusjr
Copy link
Member

uranusjr commented Apr 17, 2021

You can create an empty file with the .trivial.rst extension to skip the check yoirself.

I'm personally not sure if this should count as trivial. This is legitimately adding new things to the documentation and is worth a line.

@sbidoul
Copy link
Member

sbidoul commented Apr 18, 2021

Are we sure we want to encourage use of this non-standard syntax ?

python -m pip install 'somepackage[my-extras] @ file://$PWD/somepackage-1.0-py2.py3-none-any.whl' should work and is PEP 508 compliant.

Related: #8828

@uranusjr
Copy link
Member

The downside of PEP 508 is there's no obvious Windows-compatible format 🙁 So personally I'm OK with the non-standard syntax here since it at least is consistent to teach everywhere.

@johnthagen
Copy link
Contributor Author

@uranusjr Do you know what needs to be done to move this PR forward? Is there consensus on what we want to do?

@uranusjr
Copy link
Member

uranusjr commented Jul 8, 2021

Personally I am fine with the PR as-is, but want input from other maintainers.

@uranusjr
Copy link
Member

uranusjr commented Jul 8, 2021

p.s. the CI checks here are outdated and don’t work anymore so you need to rebase the PR to make it mergable.

@uranusjr uranusjr added the type: docs Documentation related label Jul 8, 2021
@sbidoul
Copy link
Member

sbidoul commented Jul 8, 2021

The downside of PEP 508 is there's no obvious Windows-compatible format 🙁

Yes, but we have determined in #1289 (comment) and #9471 that pip needs to be able to parse PEP 508-like requirements that have a local path instead of a URL (so we can deprecate #egg fragments).

And when that will be implemented, I think it will become the preferred format.

So today the path[extras] syntax is necessary, but in the long run we may consider to steer away from it.

@uranusjr
Copy link
Member

uranusjr commented Jul 8, 2021

Yes, but that have not happened yet, and before that happens we can still put the old format in the documentation. Once PEP 508 parsing is implemented properly, we can change the documentation to use the new format.

@johnthagen
Copy link
Contributor Author

@uranusjr I just rebased this PR on master.

@uranusjr uranusjr requested a review from sbidoul July 12, 2021 03:43
@sbidoul
Copy link
Member

sbidoul commented Jul 14, 2021

Would it make sense to at least mention the PEP 508 syntax (name[extras] @ files://fullpath) and say that the path[extras] syntax might be deprecated in the future and recommend to use it only when the PEP 508 syntax is not usable (e.g. because of the need to use a relative path).

@uranusjr
Copy link
Member

say that the path[extras] syntax might be deprecated in the future and recommend to use it only when the PEP 508 syntax is not usable

Sounds reasonable to me. @johnthagen could you make this addition?

@johnthagen
Copy link
Contributor Author

Sounds reasonable to me. @johnthagen could you make this addition?

@uranusjr I added a note for this. Does this look good?

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@uranusjr uranusjr merged commit a8b8d4d into pypa:main Jul 25, 2021
@johnthagen johnthagen deleted the patch-1 branch July 25, 2021 11:22
@johnthagen
Copy link
Contributor Author

Thanks all for helping get this merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow installing provides_extras from local wheel file
3 participants