-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to install provides_extras from local wheel file #9698
Conversation
@uranusjr Could you add the label to skip news-file for this PR? I presume this isn't large enough to warrant a news entry. |
You can create an empty file with the I'm personally not sure if this should count as trivial. This is legitimately adding new things to the documentation and is worth a line. |
Are we sure we want to encourage use of this non-standard syntax ?
Related: #8828 |
The downside of PEP 508 is there's no obvious Windows-compatible format 🙁 So personally I'm OK with the non-standard syntax here since it at least is consistent to teach everywhere. |
@uranusjr Do you know what needs to be done to move this PR forward? Is there consensus on what we want to do? |
Personally I am fine with the PR as-is, but want input from other maintainers. |
p.s. the CI checks here are outdated and don’t work anymore so you need to rebase the PR to make it mergable. |
Yes, but we have determined in #1289 (comment) and #9471 that pip needs to be able to parse PEP 508-like requirements that have a local path instead of a URL (so we can deprecate And when that will be implemented, I think it will become the preferred format. So today the |
Yes, but that have not happened yet, and before that happens we can still put the old format in the documentation. Once PEP 508 parsing is implemented properly, we can change the documentation to use the new format. |
@uranusjr I just rebased this PR on |
Would it make sense to at least mention the PEP 508 syntax ( |
Sounds reasonable to me. @johnthagen could you make this addition? |
@uranusjr I added a note for this. Does this look good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks all for helping get this merged. |
Closes #9694