Set Mypy follow_imports = silent and fix (some) typing issues found #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
uranusjr
force-pushed
the
mypy-follow-imports
branch
2 times, most recently
from
2a77f55 to
4f21ec5
Compare
pradyunsg
reviewed
Mar 10, 2021
uranusjr
force-pushed
the
mypy-follow-imports
branch
from
4f21ec5 to
56a8f3d
Compare
|
Also cc @obi1kenobi |
cjc7373
reviewed
Mar 15, 2021
|
I plan to get this into master toward the end of this weekend since it is blocking many things I want to do both in pip and resolvelib. Please do feel free to comment if you feel this is a bad idea. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9502. Most fixes are just boilerplates (I just configure away the difficult ones), but there are a few legistimate bugs found. The two most significant classes of bugs are found by converting all
canonicalize_namerecipients to useNormalizedName(@pfmoore I think you’ll be happy about this one), and convert_BaseVersionreferences toUnion[LegacyVersion, Version].