Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipenv doesn't resolve local wheel deps. #1683

Closed
ckt114 opened this issue Mar 12, 2018 · 9 comments
Closed

Pipenv doesn't resolve local wheel deps. #1683

ckt114 opened this issue Mar 12, 2018 · 9 comments
Labels
Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@ckt114
Copy link

ckt114 commented Mar 12, 2018

When installing a .whl package that we built using pipenv install package.whl it doesn't install the dependencies in package.whl.

These are the required packages in package.whl setup.py file:
install_requires=[ 'requests==2.18.4', 'PySocks==1.6.7', 'nose==1.3.7', 'redis==2.10.6', 'Sphinx==1.6.4', 'twine==1.9.1', ]

Step to replicate:
pipenv install /path/to/package.whl # Doesn't install dependencies
pip install /path/to/package.whl # Does install package.whl dependencies

@kennethreitz
Copy link
Contributor

can you try again with latest?

@kennethreitz
Copy link
Contributor

cannot reproduce with latest

@ckt114
Copy link
Author

ckt114 commented Mar 13, 2018

Why you close it so sudden? I wouldn't post it as a problem if I'm having the problem. I'll gather the info and show you.

@kennethreitz
Copy link
Contributor

make sure you're using the latest version!

@ckt114
Copy link
Author

ckt114 commented Mar 13, 2018

Sorry I might have reported the step to reproduct wrong.

What happened is that if it's a fresh new environment and I do pipenv install so it'll import my requirements.txt and the requirements.txt contains a local .whl file it only installs that .whl package, not its dependencies. I had to manually do a pipenv install package.whl for it to install the .whl dependencies.

@kennethreitz
Copy link
Contributor

ah, I see.

I'll see if we can improve this, but I make no promises.

@kennethreitz kennethreitz reopened this Mar 13, 2018
@kennethreitz kennethreitz changed the title Install local whl doesn't install that wheel's dependices Pipenv doesn't resolve local wheel deps. Mar 13, 2018
@kennethreitz kennethreitz added the Type: Enhancement 💡 This is a feature or enhancement request. label Mar 13, 2018
@techalchemy
Copy link
Member

@chngtrn if you install the requirements.txt and then pipenv update does it capture the dependencies?

@kennethreitz
Copy link
Contributor

@techalchemy pipenv lock doesn't capture the deps at all. this is fine if we document it. but, it's a caveat, currently.

kennethreitz added a commit that referenced this issue Mar 13, 2018
@ckt114
Copy link
Author

ckt114 commented Mar 13, 2018

OK. I'll deal with it then. Thanks for everything and this great project.

techalchemy added a commit that referenced this issue Apr 9, 2018
- Fixes #1937, #1683
- Modifies the resolved wheel info on the way into the lockfile to
  retain the relative path

Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy added a commit that referenced this issue Apr 9, 2018
- Fixes #1937, #1683
- Modifies the resolved wheel info on the way into the lockfile to
  retain the relative path

Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

No branches or pull requests

3 participants