New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipenv install --skip-lock broken with multiple sources #1973

Closed

jonlil opened this issue Apr 12, 2018 · 3 comments

Labels

Category: Dependency Resolution Category: Private PyPIs 😎 Type: Bug 🐛

Milestone

jonlil commented Apr 12, 2018

Considering the following Pipfile

[[source]]
url = "https://pypi.python.org/simple"
verify_ssl = true
name = "pypi"

[[source]]
url = "https://pypi.example.com/simple"
verify_ssl = true
name = "internal"

[packages]
myprivatepackage = {index = "internal", version = "==1.0.0", editable = true}
uWSGI = "==2.0.17"
unittest-xml-reporting = "*"
coverage = "*"

[dev-packages]

[requires]
python_version = "2.7"

pipenv install --verbose --skip-lock                                                                                                                                                         1 ↵
Installing dependencies from Pipfile…
Installing 'uwsgi==2.0.17 --extra-index-url https://private.example.com/simple'

WARNING: Invalid requirement, parse error at "'--extra-'"
ABORTING INSTALL... You will have to reinstall any packages that failed to install.
You may have to manually run pipenv lock when you are finished.

pipenv, version 11.9.0

I believe this might have been introduced in #1706

cc @techalchemy

The text was updated successfully, but these errors were encountered:

Member

techalchemy commented Apr 13, 2018

Seems like your analysis is correct. I’m guessing we will want to fix this by parsing this out of the requirement and setting a temporary environment variable to handle it

techalchemy added Type: Bug 🐛 Category: Dependency Resolution Category: Private PyPIs 😎 labels

Member

techalchemy commented Apr 13, 2018

Hm this issue is more complicated than I thought, will have to look further tomorrow

techalchemy added a commit that referenced this issue


          Add --extra-index-url from all extra indexes

31b6184

- Always add extra indexes when installing
- Look up indexes by key if key is given instead of url
- Fixes #1973, #1974, #1852

Signed-off-by: Dan Ryan <dan@danryan.co>

This was referenced Apr 13, 2018

Add --extra-index-url from all extra indexes #1980

Merged

install with '"e1839a8" = {path = ".", editable = true}' in Pipfile refuse to install other dependencies #1984

Closed

Member

techalchemy commented Apr 13, 2018

Try pip install -e git+https://github.com/pypa/pipenv.git@1973-extra-index-urls#egg=pipenv and let me know if it works

techalchemy added a commit that referenced this issue


          Add --extra-index-url from all extra indexes

89f933d

- Always add extra indexes when installing
- Look up indexes by key if key is given instead of url
- Fixes #1973, #1974, #1852

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Handle indexes, extra indexes, uncached sources

062b41b

- Handle extra-index-urls when resolving
- Handle extra-index-url when using `--skip-lock`
- Parse index arguments when installing individual packages
- Translate index aliases to urls
- Always include extra indexes when installing a packages
- `get_source()` falls back to `parsed_pipfile['source']` for sources when
   not present in the lockfile (#1994)
- Include index and extra-index-url arguments in `pipenv lock -r` output
- Fixes #1973, #1974, #1852, #1977, #1994

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Add --extra-index-url from all extra indexes

bab8a8f

- Always add extra indexes when installing
- Look up indexes by key if key is given instead of url
- Fixes #1973, #1974, #1852

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Handle indexes, extra indexes, uncached sources

7f08f82

- Handle extra-index-urls when resolving
- Handle extra-index-url when using `--skip-lock`
- Parse index arguments when installing individual packages
- Translate index aliases to urls
- Always include extra indexes when installing a packages
- `get_source()` falls back to `parsed_pipfile['source']` for sources when
   not present in the lockfile (#1994)
- Include index and extra-index-url arguments in `pipenv lock -r` output
- Fixes #1973, #1974, #1852, #1977, #1994

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added this to the 11.10.1 milestone

techalchemy added a commit that referenced this issue


          Add --extra-index-url from all extra indexes

6d54d0f

- Always add extra indexes when installing
- Look up indexes by key if key is given instead of url
- Fixes #1973, #1974, #1852

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Handle indexes, extra indexes, uncached sources

4dfd404

- Handle extra-index-urls when resolving
- Handle extra-index-url when using `--skip-lock`
- Parse index arguments when installing individual packages
- Translate index aliases to urls
- Always include extra indexes when installing a packages
- `get_source()` falls back to `parsed_pipfile['source']` for sources when
   not present in the lockfile (#1994)
- Include index and extra-index-url arguments in `pipenv lock -r` output
- Fixes #1973, #1974, #1852, #1977, #1994

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Add --extra-index-url from all extra indexes

917a0ac

- Always add extra indexes when installing
- Look up indexes by key if key is given instead of url
- Fixes #1973, #1974, #1852

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Handle indexes, extra indexes, uncached sources

0f299b5

- Handle extra-index-urls when resolving
- Handle extra-index-url when using `--skip-lock`
- Parse index arguments when installing individual packages
- Translate index aliases to urls
- Always include extra indexes when installing a packages
- `get_source()` falls back to `parsed_pipfile['source']` for sources when
   not present in the lockfile (#1994)
- Include index and extra-index-url arguments in `pipenv lock -r` output
- Fixes #1973, #1974, #1852, #1977, #1994

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Add --extra-index-url from all extra indexes

c0e19b1

- Always add extra indexes when installing
- Look up indexes by key if key is given instead of url
- Fixes #1973, #1974, #1852

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Handle indexes, extra indexes, uncached sources

81976f7

- Handle extra-index-urls when resolving
- Handle extra-index-url when using `--skip-lock`
- Parse index arguments when installing individual packages
- Translate index aliases to urls
- Always include extra indexes when installing a packages
- `get_source()` falls back to `parsed_pipfile['source']` for sources when
   not present in the lockfile (#1994)
- Include index and extra-index-url arguments in `pipenv lock -r` output
- Fixes #1973, #1974, #1852, #1977, #1994

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Add --extra-index-url from all extra indexes

e524f13

- Always add extra indexes when installing
- Look up indexes by key if key is given instead of url
- Fixes #1973, #1974, #1852

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Handle indexes, extra indexes, uncached sources

172a71b

- Handle extra-index-urls when resolving
- Handle extra-index-url when using `--skip-lock`
- Parse index arguments when installing individual packages
- Translate index aliases to urls
- Always include extra indexes when installing a packages
- `get_source()` falls back to `parsed_pipfile['source']` for sources when
   not present in the lockfile (#1994)
- Include index and extra-index-url arguments in `pipenv lock -r` output
- Fixes #1973, #1974, #1852, #1977, #1994

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Add --extra-index-url from all extra indexes

e054d77

- Always add extra indexes when installing
- Look up indexes by key if key is given instead of url
- Fixes #1973, #1974, #1852

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy added a commit that referenced this issue


          Handle indexes, extra indexes, uncached sources

34d34ae

- Handle extra-index-urls when resolving
- Handle extra-index-url when using `--skip-lock`
- Parse index arguments when installing individual packages
- Translate index aliases to urls
- Always include extra indexes when installing a packages
- `get_source()` falls back to `parsed_pipfile['source']` for sources when
   not present in the lockfile (#1994)
- Include index and extra-index-url arguments in `pipenv lock -r` output
- Fixes #1973, #1974, #1852, #1977, #1994

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy closed this as completed in #1980

techalchemy mentioned this issue

Running with --skip-lock fails if an extra index is defined in the Pipfile #2029

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment