WIP: Operation pewetomy #2325
Closed
WIP: Operation pewetomy #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ZSH users with HIST_IGNORE_SPACE, this will keep activation noise out of the shell’s history.
This will need A LOT of manual testing, on: * macOS * Linux * Bash * Fish * Zsh * more? * Fancy mode * Compat (default) mode Windows is surprisingly the simplest here, and I am quite sure it will work splendidly. On other platforms, I don't know. Let's see.
uranusjr
added
Category: Future
Becauss pathlib does not like trailing whitespace
This gives me cryptic errors if virtualenv_location is empty (because the None from .get() is passed into os.path.join and hell breaks loose).
uranusjr
force-pushed
the
operation-pewetomy
branch
from
ae118c7 to
e37326a
Compare
|
Moved part of this to https://github.com/pypa/pipenv/projects/3. Purge can be done later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #2161. Remove all dependence on Pew, and replace all functionality with our own implementation.
Most are quite straightforward (but still needs testing), only
newandshellrequires particular attention.newis converted to use virtualenv directly, with a little post-creation patching to make it compatible with Pew (mostly the project association stuff).shellis the coolest part. I rewrote all shell detection aspipenv.shelltools(except the NT backend is 99%_win_utilsfrom the previous implementation), and re-implementedpew.workon_cmd. I’m not that familiar with the compat shell, and largely did copy-pasting job in that part, so more testing are probably required to avoid regression.We need to manually test the hell out of this before it can land in a stable release.