Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch error when application shebang contains space and print helpful error #1230

Closed
Gitznik opened this issue Jan 25, 2024 · 3 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Gitznik
Copy link
Contributor

Gitznik commented Jan 25, 2024

How would this feature be useful?

Currently, if

  • pipx installs its virtual environments under a path with spaces, and
  • the installed application does not define an entrypoint and/or is invoked via one of its scripts

the execution fails with a bad interpreter error. See #1212 for more details.

Describe the solution you'd like

Catch this error and provide a more helpful error message. It should hint at setting PIPX_HOME to a path without spaces and raising this issue on the package that failed, with the context of our docs regarding developing for pipx.

Describe alternatives you've considered

None

@uranusjr
Copy link
Member

See also pypa/pip#12599. It is possible to support spaces in the interpreter path, so that’s an option too.

@SwarajBaral
Copy link
Contributor

I am trying to find a place where this error could be handled. Should it be during the install process itself ?

@Gitznik
Copy link
Contributor Author

Gitznik commented Apr 2, 2024

I am trying to find a place where this error could be handled. Should it be during the install process itself ?

Probably, but we now print a warning whenever we detect a space in the pipx path, so I think this issue is no longer needed 👍

@Gitznik Gitznik closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants