-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for end-of-life Pythons #131
Conversation
Here's the pip installs for pep517 from PyPI for October 2021 showing low numbers for EOL versions (<3.6):
Date range: 2021-10-01 - 2021-10-31 Source: |
pyproject.toml
Outdated
"Programming Language :: Python :: 3.6", | ||
"Programming Language :: Python :: 3.7", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Programming Language :: Python :: 3.6", | |
"Programming Language :: Python :: 3.7", | |
"Programming Language :: Python :: 3.8", | |
"Programming Language :: Python :: 3.9", |
I deliberately leave these classifiers out. The requires-python
field specifies the same thing in a more precise and useful way (useful because pip respects it), and doesn't have to be updated when a new Python version comes out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. I will remove it.
FWIW, some users use this information to determine the suitability of library within a particular project. It helps communicate precise minor versions support and how up to date a release is. Further, the trove classifiers are easier to parse so it is useful for scripts.
Thanks, and sorry it's taken me a while to get round to looking at this. It basically looks good, and the statistics @hugovk shows make a good case for it. @FFY00: do you still want a release which falls back to loading |
I don't think we need it. In |
Great, in that case I'll close #125 and go ahead with this simplification. 🙂 |
Thanks for the review @takluyver ! I have addressed all feedback in the latest revision. |
Match pip support Pythons and remove support for end-of-life Pythons. pip has not support Python 2 since 21.0 (2021-01-23). For dates on when these environments went EOL, see: https://devguide.python.org/devcycle/#end-of-life-branches Removing support for Python2 allows for several simplifications: - Remove use of toml package in favor of tomli - Remove compat.py - Replace io.open with builtin open - Replace tempdir function with tempfile.TemporaryDirectory - Replace mkdir_p function with os.makedirs - Remove use of mock package in favor of unittest.mock - Remove import from future module - Remove unnecessary inheritance from object Refs #90
Thanks @jdufresne ! |
Match pip support Pythons and remove support for end-of-life Pythons.
pip has not support Python 2 since 21.0 (2021-01-23). For dates on when
these environments went EOL, see:
https://devguide.python.org/devcycle/#end-of-life-branches
Removing support for Python2 allows for several simplifications:
Refs #90