Merge pull request #2105 from hroncok/ack_2to3

Reuse @ack_2to3 in TestDevelop.test_2to3_user_mode
pypa · May 13, 2020 · 36f9289 · 36f9289
2 parents faaaea0 + 56bcce8
commit 36f9289
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/changelog.d/2105.misc.rst b/changelog.d/2105.misc.rst
@@ -0,0 +1 @@
+Filter ``2to3`` deprecation warnings from ``TestDevelop.test_2to3_user_mode``.
diff --git a/setuptools/tests/__init__.py b/setuptools/tests/__init__.py
@@ -6,7 +6,7 @@
 
 
 __all__ = [
-    'fail_on_ascii', 'py2_only', 'py3_only'
+    'fail_on_ascii', 'py2_only', 'py3_only', 'ack_2to3'
 ]
 
 
@@ -16,3 +16,5 @@
 
 py2_only = pytest.mark.skipif(not PY2, reason="Test runs on Python 2 only")
 py3_only = pytest.mark.skipif(not PY3, reason="Test runs on Python 3 only")
+
+ack_2to3 = pytest.mark.filterwarnings('ignore:2to3 support is deprecated')
diff --git a/setuptools/tests/test_develop.py b/setuptools/tests/test_develop.py
@@ -17,6 +17,7 @@
 
 from setuptools.command.develop import develop
 from setuptools.dist import Distribution
+from setuptools.tests import ack_2to3
 from . import contexts
 from . import namespaces
 
@@ -65,6 +66,7 @@ class TestDevelop:
     @pytest.mark.skipif(
         in_virtualenv or in_venv,
         reason="Cannot run when invoked in a virtualenv or venv")
+    @ack_2to3
     def test_2to3_user_mode(self, test_env):
         settings = dict(
             name='foo',

diff --git a/setuptools/tests/test_test.py b/setuptools/tests/test_test.py
@@ -10,6 +10,7 @@
 
 from setuptools.command.test import test
 from setuptools.dist import Distribution
+from setuptools.tests import ack_2to3
 
 from .textwrap import DALS
 
@@ -73,9 +74,6 @@ def quiet_log():
     log.set_verbosity(0)
 
 
-ack_2to3 = pytest.mark.filterwarnings('ignore:2to3 support is deprecated')
-
-
 @pytest.mark.usefixtures('sample_test', 'quiet_log')
 @ack_2to3
 def test_test(capfd):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Filter ``2to3`` deprecation warnings from ``TestDevelop.test_2to3_user_mode``.