Don't keep file modes for package data.

pypa · Dec 13, 2018 · 7843688 · 7843688
1 parent 4de8dc8
commit 7843688
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/1424.change.rst b/changelog.d/1424.change.rst
@@ -0,0 +1 @@
+Prevent keeping files mode for package_data build. It may break a build if user's package data has read only flag.
diff --git a/setuptools/command/build_py.py b/setuptools/command/build_py.py
@@ -120,7 +120,7 @@ def build_package_data(self):
                 target = os.path.join(build_dir, filename)
                 self.mkpath(os.path.dirname(target))
                 srcfile = os.path.join(src_dir, filename)
-                outf, copied = self.copy_file(srcfile, target)
+                outf, copied = self.copy_file(srcfile, target, preserve_mode=False)
                 srcfile = os.path.abspath(srcfile)
                 if (copied and
                         srcfile in self.distribution.convert_2to3_doctests):