Skip to content

Commit

Permalink
Add test capturing missed expectation.
Browse files Browse the repository at this point in the history
Ref #4615
  • Loading branch information
jaraco committed Sep 3, 2024
1 parent 7ee29bd commit d901698
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions setuptools/tests/test_sdist.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import io
import logging
import os
import pathlib
import sys
import tarfile
import tempfile
Expand Down Expand Up @@ -822,6 +823,21 @@ def get_source_files(self):
manifest = cmd.filelist.files
assert '.myfile~' in manifest

@pytest.mark.xfail(reason="4615")
def test_build_base_pathlib(self, source_dir):
"""
Ensure if build_base is a pathlib.Path, the build still succeeds.
"""
dist = Distribution({
**SETUP_ATTRS,
"script_name": "setup.py",
"options": {"build": {"build_base": pathlib.Path('build')}},
})
cmd = sdist(dist)
cmd.ensure_finalized()
with quiet():
cmd.run()


def test_default_revctrl():
"""
Expand Down

0 comments on commit d901698

Please sign in to comment.