Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debt] Many ResourceWarnings when PYTHONWARNDEFAULTENCODING = 1 #3810

Open
jaraco opened this issue Feb 7, 2023 · 1 comment
Open

[debt] Many ResourceWarnings when PYTHONWARNDEFAULTENCODING = 1 #3810

jaraco opened this issue Feb 7, 2023 · 1 comment

Comments

@jaraco
Copy link
Member

jaraco commented Feb 7, 2023

In jaraco/skeleton, I've rolled out PYTHONWARNDEFAULTENCODING=1. Merging that change into Setuptools causes the test suite to fail due to pytest.ini:filterwarnings[error].
jaraco added a commit that referenced this issue Feb 7, 2023
@jaraco
Do not error on EncodingWarning. Instead emit them like usual. Ref #3810
bfd92b0 
.
jaraco added a commit that referenced this issue Feb 12, 2023
@jaraco
Do not error on EncodingWarning. Instead emit them like usual. Ref #3810
0daf2a0
jaraco added a commit that referenced this issue Feb 12, 2023
@jaraco
Do not error on EncodingWarning. Instead emit them like usual. Ref #3810
c8a6a4a
@jaraco jaraco mentioned this issue Jun 27, 2023
Closed
jaraco added a commit that referenced this issue Jul 1, 2023
@jaraco
Remove encoding warnings. Fixes #3810.
2e7bc32
jaraco added a commit that referenced this issue Jul 1, 2023
@jaraco
Remove encoding warnings. Fixes #3810.
f402142
@Avasam
Copy link
Contributor

Avasam commented Nov 28, 2023 •
edited
Loading

I figured this would be already known (it makes tests much harder to read) and I see there's a WIP branch for it.

The rule is still in "preview", but this can be checked for setuptool's own code using https://docs.astral.sh/ruff/rules/unspecified-encoding/

@Avasam Avasam mentioned this issue Feb 23, 2024
Closed
2 tasks
@Avasam Avasam mentioned this issue Mar 5, 2024
Merged
2 tasks
@abravalheri abravalheri mentioned this issue Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaraco @Avasam