Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a test that setuptools can be installed in a clean environment #1050

Merged
merged 2 commits into from
Jul 13, 2017
Merged

[WIP] Add a test that setuptools can be installed in a clean environment #1050

merged 2 commits into from
Jul 13, 2017

Conversation

alexwlchan
Copy link
Contributor

@alexwlchan alexwlchan commented Jun 1, 2017

A two-minute attempt to pick up @jaraco’s comment from #1043:

Perhaps setuptools test suite needs a test that it can be installed in a clean environment.

This script spins up a clean virtualenv without any of the usual pip/setuptools gubbins, then tries to install setuptools. What could go wrong.

I’ve confirmed this script fails on v36.0.0 and passes on v36.0.1 (so would likely have caught #1042). Not entirely sure it’s in the right place for Travis though (and might need to run on Appveyor too?).

Probably needs more tidying/cleanup, I just wanted to put up as a proof-of-concept.

@jaraco
Copy link
Member

jaraco commented Jun 1, 2017

Good start, and thanks for the proof-of-concept. I think ultimately, I'd like something that's integrated with the test suite, and maybe something that doesn't rely on virtualenv (even if it only runs on Python 3.3+). Perhaps porting this test to the test_integration.py module would achieve those goals.

But for now, this test serves the purpose, so let's start with it.

@jaraco
Copy link
Member

jaraco commented Jun 1, 2017

Hmm... except that the tests aren't passing as written. Strange error about unexpected end of file. Is there a missing carriage return in the last line?

@alexwlchan
Copy link
Contributor Author

I think it was an error in the way I’d laid out the cleanup function – more sensitive to newlines than I thought. I think the script works now.

@jaraco jaraco merged commit 03f56c9 into pypa:master Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants