Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double negative in package_discovery.rst #4017

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

bebound
Copy link
Contributor

@bebound bebound commented Aug 14, 2023

Summary of changes

find_packages() only finds the folder which contains __init__.py.

@abravalheri
Copy link
Contributor

Hi @bebound thank you very much for the contribution.

I am not sure if the meaning is correct after this change, though.

In this PR you wrote:

When you use find_packages(), all directories with an __init__.py file will be disconsidered.

That is not correct right? The directories with __init__.py will be considered...

Maybe we should have instead

When you use find_packages(), all directories without an __init__.py file will be ignored.

Does that make it easier to understand? (Note that I am reverting back to without, but changing disconsidered to ignored. Maybe that facilitates the reading?

@bebound
Copy link
Contributor Author

bebound commented Aug 14, 2023

Oh, you‘re right. I miss the dis part. Double negative makes it harder to understand.
I change it to ignore.

@bebound bebound changed the title Fix typo in package_discovery.rst Remove double negative in package_discovery.rst Aug 14, 2023
@abravalheri abravalheri merged commit 8643420 into pypa:main Aug 15, 2023
@abravalheri
Copy link
Contributor

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants