Address circular imports complaints by Sphinx 7.2+ #4023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The latest version of
sphinx
started failing in #4020 (comment) due to circular imports.Examples of the error messages are:
In this PR, I am attempting to address this problem.
The approach I used was:
setuptools/__init__.py
,setuptools/monkey.py
andsetuptools/dist.py
to avoid circular imports.import ...
andfrom ... import ...
statements, etc)setuptools.extern.packaging
andsetuptools/depends.py
andsetuptools/tests/test_setuptools.py
because for some reason the tests where complaining that theVersion
class was differing from itself (maybe the module is loaded twice?)Closes
Pull Request Checklist
newsfragments/
.(See documentation for details)