-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing annotations fixed in pkg_resources/_vendor/packaging/version.py #4044
Conversation
See also pypa/packaging#723 |
Hi @jolaf, thank you very much for the contribution. Could you please identify where the type annotation is giving you problems? Is it something inside the setuptools source. Setuptools vendors the If the |
I run my app using |
For example, from typeguard import install_import_hook
with install_import_hook(('pkg_resources',)):
import pkg_resources results in:
|
Thank you very much @jolaf for the information. In your traceback, it seems that Regarding how packaging internally handles the regex, I think the best we can do in the |
Summary of changes
I've run my app under
typeguard
and it found couple of typing annotation issues that I fix here.Closes
Pull Request Checklist
newsfragments/
.(See documentation for details)