Fix flake8-bugbear warnings #4168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B015 Pointless comparison. Did you mean to assign a value? Otherwise, prepend `assert` or remove it.
B010 Do not call `setattr` with a constant attribute value.
It is not any safer than normal property access.
B009 Do not call `getattr` with a constant attribute value.
It is not any safer than normal property access.
B033 Sets should not contain duplicate item `"anyOf"`
DimitriPapadopoulos
force-pushed
the
bugbear
branch
from
94cba4d
to
c896b46
Compare
B006 Do not use mutable data structures for argument defaults
B904 Within an `except` clause, raise exceptions with `raise ... from err`
or `raise ... from None` to distinguish them from errors in exception
handling
DimitriPapadopoulos
force-pushed
the
bugbear
branch
from
c896b46
to
68a2356
Compare
abravalheri
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Thank you very much @DimitriPapadopoulos for the valuable contribution.
Please see my comments below.
Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
abravalheri
reviewed
Jan 3, 2024
Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
2 tasks
DimitriPapadopoulos
force-pushed
the
bugbear
branch
from
6cd16cf
to
efb7997
Compare
The whole idea was to cache the result of a couple functions, do that explictly with @functools.lru_cache.
DimitriPapadopoulos
force-pushed
the
bugbear
branch
from
efb7997
to
528b60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix flake8-bugbear issues reported by ruff 0.1.9.
Pull Request Checklist
newsfragments/.(See documentation for details)