Update upload-artefact action to v3 #4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Mar 11, 2024
Avasam
changed the title
abravalheri
force-pushed
the
update-upload-artefact-action
branch
from
7142190 to
50f0459
Compare
|
Welcome to Gboard clipboard, any text you copy will be saved here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Update upload-artefact action to v3
sage would need to update their
actions/download-artifactto v4 for setuptools to updateactions/upload-artifactto v4 as well.https://github.com/sagemath/sage/blob/e417e2205be84d6d567b8897527fa6945ad09bdb/.github/workflows/docker.yml#L172-L173
Updating actions separately just in case one happens to have breaking changes that affects setuptools and/or requires further changes.
Pull Request Checklist
newsfragments/. (no user facing changes)(See documentation for details)