Fix potential problem with cog script for vendored
#4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
abravalheri
changed the title
vendoredvendored
abravalheri
force-pushed
the
fix-cog-script
branch
from
0f48d1a
to
3cfe932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Currently, the cog script may miss packages that are not listed in
vendored.txtbut get installed bypip(transitive dependencies).This change simply scans the vendored directories looking for both packages and modules that got installed.
The name was changed because it also consider
modules(in opposition topackages).The alphabetical reordering is a consequence of the way directories are listed in Python/OSs.
Closes
Pull Request Checklist
newsfragments/.(See documentation for details)