Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install all the files #4479

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Install all the files #4479

merged 6 commits into from
Jul 18, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jul 18, 2024

  • Revert "Ensure that package data from vendored packages gets installed."
  • Revert "Disable inclusion of package data as it causes 'tests' to be included as data. Fixes Release wheel 51.1.0 packs to many #2505."
  • Add test asserting cli scripts are included in wheel.
  • Remove test as it's redundant to the check in test_its_own_wheel_does_not_contain_tests.
  • Mark the file as xfail for now.

Summary of changes

Closes #4475

Pull Request Checklist

@jaraco jaraco force-pushed the bugfix/4475-all-the-files branch from a58a0a0 to b48b9ac Compare July 18, 2024 01:23
@jaraco
Copy link
Member Author

jaraco commented Jul 18, 2024

This change bumps the wheel from .9MB to 2.2MB.

@jaraco jaraco force-pushed the bugfix/4475-all-the-files branch from b48b9ac to 1ab9d5c Compare July 18, 2024 01:29
@jaraco
Copy link
Member Author

jaraco commented Jul 18, 2024

Due to #3260, it's not possible to exclude the tests.

It's more important to be able to include the important resources than to exclude unwanted ones. Ref #4475.
@jaraco jaraco force-pushed the bugfix/4475-all-the-files branch from 1ab9d5c to cf298e7 Compare July 18, 2024 01:40
@jaraco jaraco merged commit 87afa4b into main Jul 18, 2024
14 of 16 checks passed
@jaraco jaraco deleted the bugfix/4475-all-the-files branch July 18, 2024 01:40
@pelson pelson mentioned this pull request Sep 25, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 71.0.0 missing setuptools\cli-64.exe Release wheel 51.1.0 packs to many
1 participant