-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify #6
Conversation
This is rad! I'm a big fan of the simplification, but have a couple nits:
|
If you have any idea how to do this, I'm all ears. But since these are sets/dicts respectively, it'll be hard to do w/o doing some static analysis of the file. Maybe there's a flake8 plugin or something that enforces order for elements in unordered data structures? |
I mean... we can add a pytest test that reads the file, and checks if the set's contents are indeed correctly. It's OK to be slightly fragile at times. PS: I'm only slightly crazy. :) |
Created a new issue to capture this: #7. |
This PR ditches the
ClassifierNode
/ClassifierTree
entirely (along with the code generation) since we don't actually need the tree hierarchy for PyPI.Tests now run against the same
classifiers
/deprecated_classifiers
objects that end up in the package.Also, switches to CalVer.