Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #908 #1168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #908 #1168

wants to merge 2 commits into from

Conversation

DarkaMaul
Copy link

For more context, see my comment from the issue thread

The fix is simply to consider that every value of description that evaluates to False are considered as valid for an empty description.

jaraco
jaraco approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should an associated test be added to protect the behavior?

@DarkaMaul
Add a backstop-test
f37ef98 
Signed-off-by: Alexis <alexis.challande@trailofbits.com>
@DarkaMaul
Copy link
Author

I've added a backstop-test.

I've tried to keep changes contained, but feel free to rewrite them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaraco jaraco jaraco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkaMaul @jaraco