Fix py_version parsing in our Wheel class #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the basename allows us to avoid problems with bizarrely non-standard usage. Closes pypa#145
sigmavirus24
added a commit
that referenced
this pull request
Oct 28, 2015
Fix py_version parsing in our Wheel class
dnicolodi
added a commit
to dnicolodi/twine
that referenced
this pull request
Dec 19, 2024
This test file was added in 8b8790b (Add tests to ensure version parsing does not regress, part of pypa#147) with the intent of testing the target Python version from wheel file names. However, the filename is identical to the one of the other text fixture tests/fixtures/twine-1.5.0-py2.py3-none-any.whl thus it does not appear to add any additional coverage to the code extracting the target Python version.
dnicolodi
added a commit
to dnicolodi/twine
that referenced
this pull request
Dec 19, 2024
This test file was added in 8b8790b (Add tests to ensure version parsing does not regress, part of pypa#147) with the intent of testing the target Python version from wheel file names. However, the filename is identical to the one of the other text fixture tests/fixtures/twine-1.5.0-py2.py3-none-any.whl thus it does not appear to add any additional coverage to the code extracting the target Python version.
dnicolodi
added a commit
to dnicolodi/twine
that referenced
this pull request
Dec 19, 2024
This test file was added in 8b8790b (Add tests to ensure version parsing does not regress, part of pypa#147) with the intent of testing the target Python version from wheel file names. However, the filename is identical to the one of the other text fixture tests/fixtures/twine-1.5.0-py2.py3-none-any.whl thus it does not appear to add any additional coverage to the code extracting the target Python version.
dnicolodi
added a commit
to dnicolodi/twine
that referenced
this pull request
Dec 26, 2024
This test file was added in 8b8790b (Add tests to ensure version parsing does not regress, part of pypa#147) with the intent of testing the target Python version from wheel file names. However, the filename is identical to the one of the other text fixture tests/fixtures/twine-1.5.0-py2.py3-none-any.whl thus it does not appear to add any additional coverage to the code extracting the target Python version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145