Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions on how to build docs #295

Merged
merged 3 commits into from
Feb 8, 2018
Merged

Conversation

lgh2
Copy link
Contributor

@lgh2 lgh2 commented Jan 31, 2018

I added some instructions on how to build twine's docs. I used Python 3.6 in my virtual environment but I'm not sure if it's required. Please let me know if there are any changes or additions.

@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files          12       12           
  Lines         574      574           
  Branches       91       91           
=======================================
  Hits          387      387           
  Misses        162      162           
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdce8d...8a9ae0d. Read the comment docs.

virtualenvs.

Building the documentation
--------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More simply people can use tox to build the documentation. We specify it here: https://github.com/pypa/twine/blob/master/tox.ini#L13 and use it in our test suite. Instructing users to use tox -e docs will make sure everyone sees the exact same output.

@sigmavirus24
Copy link
Member

Excellent! 🍰

@sigmavirus24 sigmavirus24 merged commit 3e47035 into pypa:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants