-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/unit/create/test_creator.py::test_create_no_seed --creator venv fails on Python 3.13 #2670
Comments
The related Python 3.13 change is python/cpython#108125 |
Apparently:
This either breaks the test expectation or virtualenv behavior. Either we want the .gitignore file contents to be consistent (and hence we need to override it and/or opt-out of this feature) or we need to adjust the test to allow the venv-generated comment in it. Which one do you prefer? |
We want it to be consistent. Our ignore though should run after theirs, so we should overwrite what they create? |
https://virtualenv.pypa.io/en/20.0.24/changelog.html#bugfixes-20-0-24 Do not generate/overwrite .gitignore if it already exists at destination path - by @gaborbernat. (#1862) |
Huh! I think we should probably just adjust the test and also make sure that what we generate looks like what venv generates (mostly). |
…venv Since Python 3.13, the .gitignore file is created by venv: python/cpython#108125 Fixes pypa#2670
I started by #2672 The files only differ by the comment. |
…venv Since Python 3.13, the .gitignore file is created by venv: python/cpython#108125 Fixes pypa#2670
Issue
When I try to run the tests with Python 3.13.0a2, I see the following 8 failures:
The failure is:
I'd like to investigate, but I have no idea what is happening here. Looks likevenv
is used on Python 3.13... ?I've tied the main branch, I've tried from #2669
I've tried to add:
It still fails.
To reproduce, run
tox -e py313 -- -k test_create_no_seed -v
.Full output: virtualenv.txt
Environment
Provide at least:
pip list
of the host python wherevirtualenv
is installed:The text was updated successfully, but these errors were encountered: