BUG: pypy dlls are named differently #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
|
Hi @mattip! Thanks for the PR! I would have reviewed this but I'm not very familiar with the details of pypy so... yeah. The maintainers are basically overworked volunteers so, it usually takes a (fair) bit of time for someone to come around to reviewing PRs. Thanks for being patient! :) |
|
@pradyunsg I understand, and thanks for your work. It's just that we changed the PyPy buildbots to depend on virtualenv, and hit the modern form of issue #794 which this pull request fixes |
|
Hi If maintainers are busy and noone is willing to look properly at this simple review, can you trust us, pypy developers and just merge it? It is a blocker for gettting pypy3 working on windows |
|
I'll ping @pfmoore. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #794, in use on the pypy win32 buildbot