Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address rewrite feedback #1487

Merged
merged 20 commits into from
Jan 10, 2020
Merged

address rewrite feedback #1487

merged 20 commits into from
Jan 10, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Jan 9, 2020 •
edited
Loading

Address feedback from #1481

@gaborbernat gaborbernat changed the title move from entrypoints to importlib.metadata address rewrite feedback Jan 9, 2020
@gaborbernat gaborbernat added this to the 20.0.0 milestone Jan 9, 2020
@gaborbernat
move from entrypoints to importlib.metadata
f165801 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
xonosh is actually just xonsh
e975530 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
power-shell should be just powershell
5f30986 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
with json.dump we can enable black on activate_this
3060b8f 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
importlib-resources should be preferd over pkg_data
a2bd4ab 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
consider empty value for an env-var also false
ad32c96 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
converter already logs, mention for env-var getter
4c6d3c2 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
use S_IXUSR | S_IXGRP | S_IXOTH instead of 0755 for chmod exe
eed13e5 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
also disallow altsep beside pathsep inside paths
f0f58e4 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
handle read only errors for clear
a6a872a 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
use ast.literal_eval instead of eval
f352ee2 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
prefer if/else over try/expect for import of config parser
8f5d4f4 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
mark the project as stable
9186034 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
simplify range in creator
f391f1f 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
express that from_exe may import stuff in py_info
363b1e5 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
reorganize run.py - prefer inheritence based API over generators
d4376fd 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat mentioned this pull request Jan 10, 2020
Closed
@gaborbernat
cleanup env-vars and use venv as default dest dir instead of env
2b09fe3 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the feedback branch 3 times, most recently from 6bce748 to 5307b9e Compare January 10, 2020 15:25
@gaborbernat
fix Windows
a0c3155
@gaborbernat
simplify code logic
99616e8 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
super for __init__ in exception_
abaa112 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit 49aca38 into pypa:rewrite Jan 10, 2020
@gaborbernat gaborbernat deleted the feedback branch January 10, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gaborbernat