Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve periodic update handling #1892

Merged
merged 4 commits into from
Jul 7, 2020
Merged

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Jul 7, 2020

Resolves #1883.

Also improve output debugging.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1892 into master will increase coverage by 0.01%.
The diff coverage is 98.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
+ Coverage   93.96%   93.98%   +0.01%     
==========================================
  Files          86       86              
  Lines        4175     4220      +45     
==========================================
+ Hits         3923     3966      +43     
- Misses        252      254       +2     
Flag Coverage Δ
#tests 93.98% <98.18%> (+0.01%) ⬆️
Impacted Files Coverage Δ
src/virtualenv/report.py 97.05% <75.00%> (-2.95%) ⬇️
src/virtualenv/seed/wheels/acquire.py 100.00% <100.00%> (ø)
src/virtualenv/seed/wheels/periodic_update.py 99.04% <100.00%> (+0.21%) ⬆️
src/virtualenv/seed/embed/base_embed.py 96.22% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cf27f...cdef3ee. Read the comment docs.

@gaborbernat gaborbernat merged commit 3958bfd into pypa:master Jul 7, 2020
@gaborbernat gaborbernat deleted the https branch July 7, 2020 15:14
gaborbernat added a commit that referenced this pull request Jul 7, 2020
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not download all wheels of pip when the release history cannot be acquired
1 participant