Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add libffi-8.dll to pypy windows _shared_libs #2218

Merged
merged 2 commits into from
Oct 23, 2021
Merged

add libffi-8.dll to pypy windows _shared_libs #2218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80993fe
add libffi-8.dll to pypy windows _shared_libs
mattip Oct 20, 2021
fb36cb1
add changelog snippet
mattip Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog/2218.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
add libffi-8.dll to the hard-coded list of dlls for PyPy on Windows
2 changes: 1 addition & 1 deletion src/virtualenv/create/via_global_ref/builtin/pypy/pypy2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def modules(cls):

@classmethod
def _shared_libs(cls):
return ["libpypy-c.dll", "libffi-7.dll"]
return ["libpypy-c.dll", "libffi-7.dll", "libffi-8.dll"]

@classmethod
def sources(cls, interpreter):
Expand Down
4 changes: 2 additions & 2 deletions src/virtualenv/create/via_global_ref/builtin/pypy/pypy3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def sources(cls, interpreter):


class Pypy3Windows(PyPy3, WindowsSupports):
"""PyPy 2 on Windows"""
"""PyPy 3 on Windows"""

@property
def stdlib(self):
Expand All @@ -62,4 +62,4 @@ def bin_dir(self):

@classmethod
def _shared_libs(cls):
return ["libpypy3-c.dll", "libffi-7.dll"]
return ["libpypy3-c.dll", "libffi-7.dll", "libffi-8.dll"]