Fix broken prompt set up by activate.bat (#2225) #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the stray closing parenthesis in activate.bat in commit 35ec441 broke the virtual environment prompt prefix in Windows cmd. The reason for this was that the ill-formed closing parenthesis somehow affected the variable expansion order. This commit fixes the issue by not using a local ENV_PROMPT variable to update the prompt. (So an additional benefit of this change is one less variable set in the environment.) Fixes: pypa#2225
|
Thank you for putting this in. I'll be able to have a look at it tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the stray closing parenthesis in activate.bat in commit
35ec441 broke the virtual environment prompt prefix in Windows cmd.
The reason for this was that the ill-formed closing parenthesis
somehow affected the variable expansion order.
This commit fixes the issue by not using a local ENV_PROMPT
variable to update the prompt. (So an additional benefit of
this change is one less variable set in the environment.)
Fixes: #2225
Thanks for contributing, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint)docs/changelogfolder