Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pinned version are not working once periodic / manual updates kick-in #2256

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Dec 28, 2021

This extends the periodic_update function to take & respect the of_version argument as computed by from_bundle function (exact version or None).
Without this, the function would always return the most recent wheel found during a periodic/manual update without any regards to the exact version the user asked for.

Fixes #2203

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@mayeut
Copy link
Member Author

mayeut commented Dec 28, 2021

@pypa/virtualenv-committers,

do you have any recommendations / feedback on the inline comments before I take this a bit further ?
what direction would you want this to go ?

@mayeut mayeut force-pushed the seed-version branch 2 times, most recently from 83fe2c3 to 18c66de Compare December 29, 2021 00:44
@mayeut mayeut marked this pull request as ready for review December 29, 2021 09:55
@mayeut
Copy link
Member Author

mayeut commented Dec 29, 2021

Comments have been addressed.

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat merged commit c3c4f7a into pypa:main Dec 29, 2021
@gaborbernat
Copy link
Contributor

This now has been released under https://pypi.org/project/virtualenv/20.11.2/, thanks for your contribution!

@mayeut mayeut deleted the seed-version branch December 29, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--setuptools doesn't install pinned version
2 participants