Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: store version update source in embed JSON file #2273

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Dec 31, 2021

Store version update source in embed JSON file.
For now, the source can take the value periodic or manual (not enforced to allow future sources).
Only periodic & manual sources are allowed to provide an update path for a bundle version.
Running a manual update marks all versions source as manual.
Running a periodic update marks all versions source as periodic if the source value is not manual.

The following issues are fixed:

This will also allow to implement #2268 with a new source (e.g. download).

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@mayeut mayeut marked this pull request as draft December 31, 2021 18:42
@mayeut mayeut force-pushed the update-embed-cache branch 2 times, most recently from 17c0c94 to f56ae87 Compare December 31, 2021 19:31
@mayeut mayeut marked this pull request as ready for review December 31, 2021 20:46
@gaborbernat gaborbernat merged commit 4308ddb into pypa:main Jan 1, 2022
@gaborbernat
Copy link
Contributor

@mayeut hey thanks for the great contributions, I'd be happy to have you along as co-maintainer for the project if you're interested 👌

@mayeut mayeut deleted the update-embed-cache branch January 1, 2022 10:52
@mayeut
Copy link
Member Author

mayeut commented Jan 1, 2022

I'd be happy to have you along as co-maintainer for the project if you're interested

@gaborbernat, thanks for the offer but I've got my hands full with other open source projects (& the day job) so I'll probably not be useful as a co-maintainer. I will continue contributing once in a while depending on those other projects needs (mostly cibuildwheel w.r.t. virtualenv). I see this PR as a way towards #2268 so it was not really to fix issues that I opened it but rather to enable the enhancement.

@gaborbernat
Copy link
Contributor

Sounds good 👍 and if you change your mind the offer stands. No pressure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants