Windows embedable support #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
For example, for Python 3.10 the embeddable file name would be "python310.zip". If this file would be found in `sys.path`, the virtualenv should copy it into the "<venv>\Scripts\python310.zip".
Helps to test virtualenv creator classes.
gaborbernat
requested changes
Jun 9, 2022
Of course. Just give me some time) |
The importlib accepts a Path-like objects from Python 3.6
It is possible to make pass CPython3 tests under Python 2, but it's better to disable it instead of decreasing the readability and performance of Python 3 style.
|
Hm. Looks like last PR must fix 1 test here. |
|
Can you rebase the PR on main? |
|
I expected the error to occurs in this PR #2363 and I fix it. But it seems we need to merge that PR and restart tests here to see logs and catch the error. New logs should tell us more about the error, at least the path to non-existent file. |
|
Merged now so you'll need to rebase against main 👍 |
|
Wow) I expected an exception, but OK) |
|
with this PR, I'm now getting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox -e fix_lint)docs/changelogfolderAfter these steps #1774 (comment)
the embeddable Python should works fine with virtualenv.
Virtualenv now ships zipped std lib packages along with other dll and pyd files.