Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run scheduled workflow jobs on forks #2490

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

nsoranzo
Copy link
Contributor

@nsoranzo nsoranzo commented Jan 18, 2023

Saves the environment, and less emails for me when the scheduled workflow run fails.

Also:

  • Always test package building by preventing only the "Publish to PyPi" step from running on pull requests, branches and forks.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Also:
- Always test package building by preventing only the "Publish to PyPi"
  step from running on pull requests, branches and forks.
@gaborbernat gaborbernat merged commit ab35ce4 into pypa:main Feb 4, 2023
@nsoranzo nsoranzo deleted the no_scheduled_wf_runs_on_forks branch February 4, 2023 12:45
joelvaneenwyk pushed a commit to joelvaneenwyk/virtualenv that referenced this pull request Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants