-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows CPython interpreters distributed by non-standard orgs #2504
Conversation
Window Registry does not contain implementation (e.g. CPython) information
Testing here a straightforward fix whereby the Windows Registry-based pre-filtering is removed altogether. I assume this pre-filtering is there for performance reasons? The issue with the Window Registry-based pre-filtering is that implementation meta data is not available. Previously a hack was implemented to map organizations "PythonCore" and "Continuum" to the "CPython" implementation. That obviously does not work for anyone else! In any case, the existing logic applied full matching based on meta-data provided by the interpreter executable itself. That logic is cached in any case, so normally we expect this to be evaluated once per interpreter. That seems to suggest the Windows Registry-based optimization is largely redundant? This would also bring it in line with the Linux implementation which simply relies on interpreter paths on the |
Local test runs seem to suggest existing tests are fully passing with this change. @gaborbernat Are you able to approve the GH Actions workflow to confirm the tests are green? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test and changelog needs to be added.
Understood - have some tests replicating the issue that I need to tidy up first. Just looking for guidance whether this is at all a solution you're willing to consider @gaborbernat |
For info, I am still trying to find a good testing strategy that covers the |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…eature/win-reg-org-name
@gaborbernat This should be a complete PR, if you are able to approve the workflows and review, that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loooks ok in general 👍
@gaborbernat I think that's all feedback addressed. Thanks! |
Appreciate your status atm @gaborbernat. Any indication when we might be able to merge and release this? |
beautiful! |
…pypa#2504) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
See issue #2491
tox -e fix_lint
)docs/changelog
folder