Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReentrantFileLock thread-safe and, thereby, fix race condition in virtualenv.cli_run #2517

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

radoering
Copy link
Contributor

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Resolves: #2516

This PR makes ReentrantFileLock thread-safe and, thereby, fixes a race condition in virtualenv.cli_run.

@gaborbernat gaborbernat merged commit d48565f into pypa:main Mar 12, 2023
tarpas pushed a commit to tarpas/virtualenv that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

virtualenv.cli_run is not thread-safe
2 participants