update nushell's str collect command to str join #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These CI failures seem unrelated to this PR. Could someone please take a look? BTW - One macos test failed yesterday due to timeout. I pushed an empty commit this morning to try and get it to rerun. That's when this other test failure showed up. It's looking like |
gaborbernat
approved these changes
Mar 31, 2023
|
Thanks @gaborbernat!! |
tarpas
pushed a commit
to tarpas/virtualenv
that referenced
this pull request
Jun 8, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've deprecated the nushell command
str collecta few months ago. We've replaced it withstr join. This PR makes these changes in the activate.nu script.Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder