Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 support #2548

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Drop Python 2 support #2548

merged 1 commit into from
Apr 19, 2023

Conversation

gaborbernat
Copy link
Contributor

Signed-off-by: Bernát Gábor bgabor8@bloomberg.net

@gaborbernat gaborbernat force-pushed the no-py-2 branch 7 times, most recently from 201dad5 to 54f9d11 Compare April 19, 2023 21:30
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@EKTehtris
Copy link

Hi would have been better to release 21.X.X for this as this is a breaking change, but thx for mentionning it in the changelog

@encukou
Copy link

encukou commented Apr 28, 2023

FWIW, there are still environments that need to support a rather wide range of Python versions. To use virtualenv (and tox) with all of 3.6-3.12, we'll need to patch and diverge. Hopefully we don't mess up too much.

@gaborbernat
Copy link
Contributor Author

Just pin to an older version of virtualenv. No need to patch.

@zzzeek
Copy link

zzzeek commented Apr 30, 2023

just agreeing with @EKTehtris that if virtualenv is trying to do semver, this really should have been 21.0.0. "version 20.22.0" seems pretty "semver" already (i.e. it's not like "20" or "21" is that special of a number).

as far as realistic downstream impact, seeing a major number jump would have made it more obvious why tox stopped working for our CI builds that are still running py2.

@gaborbernat
Copy link
Contributor Author

gaborbernat commented Apr 30, 2023

I understand what you're saying but if every library would bump a major version whenever they are dropping support for a very old and long time not supported interpreter numbers would get very high. tox would have been just as much broken with a new major or minor. Python 2 is end of life for 2 and 1/2 years. So if you still have CI running for it, those projects are probably doomed no matter what.

@pypa pypa locked and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants