-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1949: zipapp virtual environment creation fails if zipapp path is symlinked #2613
Conversation
@gaborbernat I see the following possible solutions:
How do you want me to proceed? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests validating your change fixes the problem.
full_path = os.path.realpath(os.path.abspath(str(full_path))) | ||
prefix = ROOT + os.sep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use here the pathlib variant instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I saw most of the other code uses pathlib, but I wasn't sure whether it's intentional or not, and wanted to keep the size of the diff minimal. It's way simpler to implement the whole function using PurePath.relative_to
anyway.
Question: if I migrate to pathlib, the trivial implementation will throw ValueError in case ROOT
and full_path
diverge, i.e. when my assert fails in the current version. Is that acceptable, or should I turn it back to an assert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ValueError is fine considering we're not expecting it to happen.
Can you point me in the direction of where it should be added? I'm not that familiar with either pytest or tox. I also don't know how I could make sure the test passes because the issue is really fixed, or because of the caching behaviour described in the original report. Or should I add a unit test for the zipapp functionality specifically? Would the place for that be in |
You want to add it here https://github.com/pypa/virtualenv/blob/main/tests/integration/test_zipapp.py |
Seems stalled, closing until you pick it up again. |
Yeah, sorry, I'm swamped, and I'll be AFK next week. I hope to eventually get back to this and reopen... |
Original issue: #1949
The function in question assumes that
ROOT
is a prefix offull_path
, and tries to remove it. However, it is not necessarily a prefix:ROOT
is determined, bothos.path.abspath()
andos.path.realpath()
gets calledfull_path
is determined, onlyos.path.abspath()
is calledThis means that if the path contains a symlink, it will show up as resolved in
ROOT
, but notfull_path
, so simply removing the first X characters offull_path
is not sufficient.This PR adds an assertion to catch the bad situation early, then adds the
os.path.realpath
call tofull_path
.I did not add a test because I was unable to figure out how to add it to the existing structure.
tox -e fix
)docs/changelog
folder